164 bug time panel doesnt show chosen time interval correctly #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the time range dropdown preset selection was not properly exiting Custom mode. The issue occurred because preset time ranges were calculated once at component mount and became stale, preventing the system from recognizing when users selected matching presets.
Changes:
- Updated the
useMemodependency array for thepresetscalculation to recalculate when the menu or picker opens - Updated CHANGELOG.md to document the bug fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Components/Entry/TimeRangeDropdown.tsx | Added menuOpen and pickerOpen to the presets memoization dependencies to ensure time-based presets are recalculated with current time when the picker/menu opens |
| CHANGELOG.md | Added entry documenting the bug fix (with incorrect PR number reference) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nterval-correctly
AnthonyCvn
deleted the
164-bug-time-panel-doesnt-show-chosen-time-interval-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #164
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What was changed?
Fix time range dropdown preset selection not exiting Custom mode
Related issues
No
Does this PR introduce a breaking change?
No
Other information: